Adding article on jQuery widget method invocation. #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ``` | ||
| $( ".selector" ) | ||
| .dialog( "isOpen" ) | ||
| .css( "color", "red" ); |
There was a problem hiding this comment.
How about a line comment above the .css call, something like // this will throw a TypeError (or whatever it throws). That will make the issue more clear, since the two examples look very similar.
|
Apart from the line comment this looks good to me. |
|
Good call. It is a |
|
👍 Feel free to land this. |
|
Landed in 4cf8c56. |
|
Shouldn't this mention that invoking most methods directly on the instance will return undefined? |
|
@scottgonzalez Yeah probably. How about this - #431? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up as part of jquery/api.jqueryui.com#164.